Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: identify mls capable client #15841

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented Sep 18, 2023

Description

Fixes the way we identify a client being MLS capable. We were mistakenly assuming that client with mls_public_keys field is an mls client (even if this field contained empty object, see wireapp/wire-web-packages#5516). mls_public_keys is empty object by default, we need to check if it really contains any values (Public key is uploaded after mls device is registered).

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #15841 (622104d) into dev (2914fe6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev   #15841   +/-   ##
=======================================
  Coverage   44.48%   44.48%           
=======================================
  Files         673      673           
  Lines       22715    22717    +2     
  Branches     5166     5166           
=======================================
+ Hits        10104    10106    +2     
  Misses      11323    11323           
  Partials     1288     1288           

@PatrykBuniX PatrykBuniX merged commit 1fda360 into dev Sep 18, 2023
13 checks passed
@PatrykBuniX PatrykBuniX deleted the runfix/identify-mls-capable-client branch September 18, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants