Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: Make sure we save new users loaded via the user modal #15843

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Sep 18, 2023

Description

Since #15813 we refresh rather than get the user when loading the userModal. Which means that if the user is not present locally, we will not save the user entity locally.
This makes sure that when calling refresh we save any new user coming in

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@atomrc atomrc requested review from otto-the-bot and a team as code owners September 18, 2023 12:17
@atomrc atomrc changed the title Runfix/connection runfix: Make sure we save new users loaded via the user modal Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #15843 (a23df85) into dev (1fda360) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##              dev   #15843   +/-   ##
=======================================
  Coverage   44.48%   44.48%           
=======================================
  Files         673      673           
  Lines       22717    22719    +2     
  Branches     5166     5166           
=======================================
+ Hits        10106    10107    +1     
- Misses      11323    11324    +1     
  Partials     1288     1288           

@atomrc atomrc merged commit 2979a63 into dev Sep 18, 2023
15 checks passed
@atomrc atomrc deleted the runfix/connection branch September 18, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants