Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set emoji image draggable attribute to false (WPB-4775) #15856

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Sep 20, 2023

BugWPB-4775 Drag and drop sends a message immediately without confirmation

Description

Emoji pill's image could get dragged, dropped and sent as a new message by accident on certain OSs
Setting the html attribute draggable to false prevents that issue

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #15856 (ff03392) into dev (4845430) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #15856   +/-   ##
=======================================
  Coverage   44.51%   44.51%           
=======================================
  Files         673      673           
  Lines       22733    22733           
  Branches     5168     5168           
=======================================
  Hits        10120    10120           
  Misses      11321    11321           
  Partials     1292     1292           

@V-Gira V-Gira changed the title fix: set emoji image draggable attribute to false fix: set emoji image draggable attribute to false (WPB-4775) Sep 20, 2023
@V-Gira V-Gira merged commit 1b7fd5a into dev Sep 20, 2023
23 checks passed
@V-Gira V-Gira deleted the virgile/emoji-draggable-attribute branch September 20, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants