feat: refresh self protocols on team refresh #15897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #15897 +/- ##
=======================================
Coverage 44.53% 44.53%
=======================================
Files 674 674
Lines 22756 22758 +2
Branches 5175 5175
=======================================
+ Hits 10134 10135 +1
- Misses 11325 11326 +1
Partials 1297 1297 |
przemvs
approved these changes
Sep 27, 2023
atomrc
reviewed
Sep 28, 2023
| @@ -156,6 +157,7 @@ export class TeamRepository extends TypedEventEmitter<Events> { | |||
| try { | |||
| await this.getTeam(); | |||
| await this.updateFeatureConfig(); | |||
| this.emit('teamRefreshed'); | |||
There was a problem hiding this comment.
suggestion: maybe we could narrow down the scope of this event to just featureConfigUpdated and move it to the updateFeatureConfig function (this way we are sure this event will emit even if we just update the config and not the entire team). WDYT?
There was a problem hiding this comment.
updateFeatureConfig is called every time any of the feature is updated though, so we would refresh protocols too often in my opinion.
There was a problem hiding this comment.
Hummm I see. ok then, fine for now 👍
atomrc
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes user refresh self supported protocols after team (and its whole feature list) was refreshed. This happens every 24h.