Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont run the MLSStateHandler without MLS enabled #15994

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

aweiss-dev
Copy link
Member

This PR fixes the problem that the MLSConversationVerificationStateHandler Class gets instantiated with disabled MLS.

@aweiss-dev aweiss-dev requested review from otto-the-bot and a team as code owners October 12, 2023 13:23
@aweiss-dev aweiss-dev changed the title fix: dont run the MLSConversationVerificationStateHandler without MLS… fix: dont run the MLSStateHandler without MLS enabled Oct 12, 2023
this.core,
);

if (Config.getConfig().FEATURE.ENABLE_MLS === true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a supportsMLS function in util.ts file we can use instead.

@aweiss-dev aweiss-dev enabled auto-merge (squash) October 12, 2023 13:56
@aweiss-dev aweiss-dev merged commit e34ed6c into dev Oct 12, 2023
11 checks passed
@aweiss-dev aweiss-dev deleted the fix/mlsStateHandler branch October 12, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants