fix: Use qualified Ids when matching users for search filtering [WPB-4823]

[atomrc]

WPB-4823 [Web] [Bundestag] Team members not showing up in group search

Description

This attempts to fix an issue where some local users could not be found in the search.
The theory being: since we try to match users by comparing actual user entities (the entire object), if 2 different entities represent the same user, then the check will be false.

const userId = 'user1';
const userA = new User(userId);
const userB = new User(userId);

userA === userB; // false ❌

To fix that, we now match users only by their IDs (which means that 2 entities representing the same user would return true)

const userId = 'user1';
const userA = new User(userId);
const userB = new User(userId);

userA.id === userB.id; // true ✅

Checklist

• PR has been self reviewed by the author;
• Hard-to-understand areas of the code have been commented;
• If it is a core feature, unit tests have been added;

[codecov]

Codecov Report

Merging #16138 (8130e04) into dev (945cb70) will increase coverage by 0.00%.
The diff coverage is 25.00%.

❗ Current head 8130e04 differs from pull request most recent head 0cdb723. Consider uploading reports for the commit 0cdb723 to get more accurate results

@@           Coverage Diff           @@
##              dev   #16138   +/-   ##
=======================================
  Coverage   44.59%   44.59%           
=======================================
  Files         707      707           
  Lines       23133    23132    -1     
  Branches     5259     5260    +1     
=======================================
  Hits        10316    10316           
+ Misses      11474    11473    -1     
  Partials     1343     1343           

[atomrc]

no, it's actually any kind of conversation (including group conversations). We can have unconnected users there (as opposed to what the connectedUsers suggests 😬 )