Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: Handle mention deletion edge cases #16167

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

atomrc
Copy link
Contributor

@atomrc atomrc commented Nov 8, 2023

Description

fixes a bunch of edge case when dealing with deleting mentions, namely:

  • deleting mention when the entire text is selected
  • fixing the selection after a mention has been deleted

Screenshots/Screencast (for UI changes)

Screen.Recording.2023-11-08.at.15.46.18.mp4

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #16167 (da75514) into dev (dfa6dd7) will decrease coverage by 0.02%.
Report is 1 commits behind head on dev.
The diff coverage is 4.76%.

@@            Coverage Diff             @@
##              dev   #16167      +/-   ##
==========================================
- Coverage   44.69%   44.68%   -0.02%     
==========================================
  Files         706      706              
  Lines       23100    23092       -8     
  Branches     5262     5266       +4     
==========================================
- Hits        10325    10318       -7     
  Misses      11444    11444              
+ Partials     1331     1330       -1     

@atomrc atomrc merged commit 77f9525 into dev Nov 8, 2023
21 checks passed
@atomrc atomrc deleted the runfix/delete-mention branch November 8, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants