Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: calls in mls 1:1 conversations #16255

Merged
merged 3 commits into from
Nov 22, 2023
Merged

runfix: calls in mls 1:1 conversations #16255

merged 3 commits into from
Nov 22, 2023

Conversation

PatrykBuniX
Copy link
Contributor

Description

This PR ensures that client will not try to fetch/join MLS conference subconversations for 1:1 MLS conversation calls. Subconversations are only supported by regular group mls conversations. For 1:1 MLS conversations we should use the same type we do for proteus 1:1 conversations - ONEONONE (0).

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #16255 (d5cb4e3) into dev (845c328) will decrease coverage by 0.09%.
Report is 1 commits behind head on dev.
The diff coverage is 44.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #16255      +/-   ##
==========================================
- Coverage   45.27%   45.19%   -0.09%     
==========================================
  Files         708      708              
  Lines       23341    23354      +13     
  Branches     5329     5330       +1     
==========================================
- Hits        10567    10554      -13     
- Misses      11413    11451      +38     
+ Partials     1361     1349      -12     

@PatrykBuniX PatrykBuniX marked this pull request as ready for review November 22, 2023 10:26
@PatrykBuniX PatrykBuniX merged commit f4daa27 into dev Nov 22, 2023
13 checks passed
@PatrykBuniX PatrykBuniX deleted the runfix/1to1-mls-calls branch November 22, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants