ci: use prerelase names with dot #16377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #16377 +/- ##
==========================================
- Coverage 45.57% 45.44% -0.14%
==========================================
Files 733 733
Lines 23723 23723
Branches 5398 5398
==========================================
- Hits 10812 10781 -31
- Misses 11546 11576 +30
- Partials 1365 1366 +1 |
tlebon
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #16370
This PR updates the way the Helm chart prelrease versions are created. You are supposed to put a
.before the counter. That way the semver ordering is like you expected. Concretely0.4.0-pre9is bigger than0.4.0-pre10. You are doing it wrong0.4.0-pre.9is smaller than0.4.0-pre.10. That's right 👍The bump in
Chart.yamlis to trigger a new prerelease