feat: New tooltip preparation #16776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/q1-2024 #16776 +/- ##
==================================================
Coverage ? 45.78%
==================================================
Files ? 745
Lines ? 24438
Branches ? 5581
==================================================
Hits ? 11190
Misses ? 11824
Partials ? 1424 |
atomrc
reviewed
Feb 8, 2024
| )} | ||
|
|
||
| {sender.isDirectGuest() && !sender.isFederated && ( | ||
| <span | ||
| className="message-header-icon-guest with-tooltip with-tooltip--external" |
There was a problem hiding this comment.
could we also delete those css declarations? Are they still used?
There was a problem hiding this comment.
Yes, this class is used :)
E.g. with class:
without class:
There was a problem hiding this comment.
so they are still used in the code, right
przemvs
added a commit
that referenced
this pull request
Feb 8, 2024
* feat: New tooltip preparation * remove unecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-6320
Description
Created new tooltips which is visible all of the time whenever You hover element with tooltip. Now tooltips are not cutted.
Tooltips works dynamically, if on top will not place for tooltip, will be placed under hovered element.
Also version bump for @wireapp/react-ui-kit from 9.12.8 to 9.15.1 (New tooltips included).
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)