fix: Prepare image placeholder for not loaded image and prevent jumping #16941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #16941 +/- ##
==========================================
+ Coverage 46.03% 46.08% +0.04%
==========================================
Files 746 746
Lines 24395 24411 +16
Branches 5582 5585 +3
==========================================
+ Hits 11231 11249 +18
+ Misses 11746 11743 -3
- Partials 1418 1419 +1 |
V-Gira
reviewed
Feb 28, 2024
Comment on lines
269
to
276
| {[StatusType.FAILED, StatusType.FEDERATION_ERROR].includes(status) && ( | ||
| <CompleteFailureToSendWarning | ||
| {...(status === StatusType.FEDERATION_ERROR && {unreachableDomain: conversation.domain})} | ||
| isMessageFocused={msgFocusState} | ||
| onRetry={() => onRetry(message)} | ||
| /> | ||
| )} | ||
|
|
There was a problem hiding this comment.
let's leave this out of this PR, it's not related to Image scrolling at all
This doesn't take into account fed errors
Let me take care of this in an other pr
There was a problem hiding this comment.
I revereted it manually.
V-Gira
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before: Image placeholder won't render correctly, have different size than rendered image.
Now: Image placeholder and image has same size.
Screenshots/Screencast (for UI changes)
Checklist
Important details for the reviewers
(Delete this section if unnecessary)