runfix: e2ei basic device enrollment [WPB-9816] #17444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatrykBuniX
commented
May 22, 2024
| const isNotActivated = identity?.status === MLSStatuses.NOT_ACTIVATED; | ||
| const isBasicDevice = identity?.credentialType === CredentialType.Basic; | ||
|
|
||
| const isFirstE2EIActivation = !storedE2eActivatedAt && (!identity || isNotActivated || isBasicDevice); |
There was a problem hiding this comment.
The boolean did exist before, it didn't take basic devices into account while deciding whether it should execute the task immediately.
aweiss-dev
approved these changes
May 23, 2024
otto-the-bot
added a commit
that referenced
this pull request
May 23, 2024
* Revert "fix: show enrollment modal for existing clients after e2ei activation [WPB-9816] (#17422)" This reverts commit 72c8c63. * runfix: show modal for a basic device * runfix: old client can snooze the enrollment * test: enrollment for basic credential type Co-authored-by: Patryk Górka <patrykbunix@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the handling of displaying the enrollment modal for an existing client after enabling the e2ei feature.
Screenshots/Screencast (for UI changes)
Checklist