fix: Change active conversation on click on filtered conversation #18110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweiss-dev
reviewed
Sep 30, 2024
| function initBorderedScroll(element: HTMLElement | null) { | ||
| if (!element) { | ||
| return; | ||
| // @ts-ignore |
There was a problem hiding this comment.
this is usually a yellow flag. why is the type not detected correctly?
There was a problem hiding this comment.
overlooked? It needs to be addressed for the tests in any case
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18110 +/- ##
=======================================
Coverage 46.39% 46.40%
=======================================
Files 794 794
Lines 25594 25605 +11
Branches 5852 5853 +1
=======================================
+ Hits 11875 11881 +6
- Misses 12233 12238 +5
Partials 1486 1486 |
e-maad
approved these changes
Oct 2, 2024
przemvs
deleted the
fix/WPB-11097-fix-for-conversation-scrolling-while-filtering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist