fix(cloudflare): routing strategy doesn't support on-demand 404 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ad2a328 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
matthewp
approved these changes
Nov 16, 2023
natemoo-re
approved these changes
Nov 16, 2023
sarah11918
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
These changesets are looking so good, @alexanderniebuhr ! 🙌
lilnasy
reviewed
Nov 16, 2023
alexanderniebuhr
deleted the
nbhr/fix_cloudflare_routing_strategy_doesn_t_support_on-demand_404
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
excludestrategy forauto, to make sure routing works as expected on Cloudflare's SPA mode_routes.jsongeneration #64