fix(svelte): unmount islands properly on navigation (#8448)

withastro · Sep 7, 2023 · 3f49aa9 · 3f49aa9
1 parent f3f62a5
commit 3f49aa9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/sweet-sheep-sell.md b/.changeset/sweet-sheep-sell.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/svelte': patch
+---
+
+Fix potential memory leak when component is unmounted
diff --git a/packages/integrations/svelte/client.js b/packages/integrations/svelte/client.js
@@ -3,9 +3,9 @@ const noop = () => {};
 let originalConsoleWarning;
 let consoleFilterRefs = 0;
 
-export default (target) => {
+export default (element) => {
 	return (Component, props, slotted, { client }) => {
-		if (!target.hasAttribute('ssr')) return;
+		if (!element.hasAttribute('ssr')) return;
 		const slots = {};
 		for (const [key, value] of Object.entries(slotted)) {
 			slots[key] = createSlotDefinition(key, value);
@@ -15,7 +15,7 @@ export default (target) => {
 			if (import.meta.env.DEV) useConsoleFilter();
 
 			const component = new Component({
-				target,
+				target: element,
 				props: {
 					...props,
 					$$slots: slots,