Updates based on PR review

examples/basics/astro.config.mjs

@@ -1,6 +1,4 @@
 import { defineConfig } from 'astro/config';
-import netlify from "@astrojs/netlify";
-
 
 // https://astro.build/config
 export default defineConfig({});

packages/astro/src/@types/astro.ts

@@ -621,7 +621,7 @@ export interface AstroUserConfig {
 	/**
 	 * @docs
 	 * @kind heading
-	 * @name Adapter
+	 * @name Deploy
 	 * @description
 	 *
 	 * Deploy to your favorite server, serverless, or edge host with build adapters. Import one of our first-party adapters for [Netlify](https://docs.astro.build/en/guides/deploy/netlify/#adapter-for-ssredge), [Vercel](https://docs.astro.build/en/guides/deploy/vercel/#adapter-for-ssr), and more to engage Astro SSR.
@@ -632,7 +632,7 @@ export interface AstroUserConfig {
 	 * import netlify from '@astrojs/netlify/functions';
 	 * {
 	 *   // Example: Build for Netlify serverless deployment
-	 * 	 adapter: netlify(),
+	 * 	 deploy: netlify(),
 	 * }
 	 * ```
 	 */

packages/astro/src/core/build/index.ts

@@ -101,15 +101,7 @@ class AstroBuilder {
 		};
 		await runHookBuildStart({ config: this.config, buildConfig });
 
-		const getPrettyDeployTarget = (adapter: AstroAdapter | undefined) => {
-			if (adapter?.name === 'node') {
-				return 'node.js (generic)';
-			}
-			if (adapter?.name) {
-				return adapter?.name;
-			}
-			return 'unknown';
-		}
+		const getPrettyDeployTarget = (adapter: AstroAdapter | undefined) => adapter?.name || 'unknown';
 		info(this.logging, 'build', `build target: ${colors.green(this.config.mode)}`);
 		info(this.logging, 'build', `deploy target: ${colors.green(getPrettyDeployTarget(this.config._ctx.adapter))}`);
 		info(this.logging, 'build', 'Collecting build info...');

packages/astro/src/core/build/static-build.ts

@@ -6,7 +6,7 @@ import { fileURLToPath } from 'url';
 import * as vite from 'vite';
 import { BuildInternals, createBuildInternals } from '../../core/build/internal.js';
 import { prependForwardSlash } from '../../core/path.js';
-import { emptyDir, removeDir } from '../../core/util.js';
+import { emptyDir, removeDir, isModeServerWithNoAdapter } from '../../core/util.js';
 import { runHookBuildSetup } from '../../integrations/index.js';
 import { rollupPluginAstroBuildCSS } from '../../vite-plugin-build-css/index.js';
 import type { ViteConfigWithSSR } from '../create-vite';
@@ -25,7 +25,7 @@ export async function staticBuild(opts: StaticBuildOptions) {
 	const { allPages, astroConfig } = opts;
 
 	// Verify this app is buildable.
-	if(opts.astroConfig.mode === 'server' && !opts.astroConfig._ctx.adapter) {
+	if(isModeServerWithNoAdapter(opts.astroConfig)) {
 		throw new Error(`Cannot use mode: 'server' without an adapter. Please install and configure an adapter by setting it on the deploy configuration.
 		
 export default {

packages/astro/src/core/logger/node.ts

@@ -125,7 +125,6 @@ export const logger = {
 };
 
 export function enableVerboseLogging() {
-	debugPackage.enable('*,-babel');
 	debug('cli', '--verbose flag enabled! Enabling: DEBUG="*,-babel"');
 	debug(
 		'cli',

packages/astro/src/core/util.ts

@@ -182,15 +182,8 @@ export function isPage(file: URL, config: AstroConfig): boolean {
 	return endsWithPageExt(file, config);
 }
 
-export function isBuildingToSSR(config: AstroConfig): boolean {
-	const adapter = config._ctx.adapter;
-	if (!adapter) return false;
-
-	if (typeof adapter.serverEntrypoint === 'string') {
-		return true;
-	} else {
-		return false;
-	}
+export function isModeServerWithNoAdapter(config: AstroConfig): boolean {
+	return config.mode === 'static' && !config._ctx.adapter;
 }
 
 export function emoji(char: string, fallback: string) {

packages/integrations/cloudflare/src/index.ts

@@ -21,6 +21,10 @@ export default function createIntegration(): AstroIntegration {
 			'astro:config:done': ({ setAdapter, config }) => {
 				setAdapter(getAdapter());
 				_config = config;
+
+				if(config.mode === 'static') {
+					console.warn(`@astrojs/cloudflare does not support static mode.`);
+				}
 			},
 			'astro:build:start': ({ buildConfig }) => {
 				_buildConfig = buildConfig;

packages/integrations/deno/src/index.ts

@@ -29,8 +29,12 @@ export default function createIntegration(args?: Options): AstroIntegration {
 	return {
 		name: '@astrojs/deno',
 		hooks: {
-			'astro:config:done': ({ setAdapter }) => {
+			'astro:config:done': ({ setAdapter, config }) => {
 				setAdapter(getAdapter(args));
+
+				if(config.mode === 'static') {
+					console.warn(`@astrojs/deno does not support static mode.`);
+				}
 			},
 			'astro:build:start': ({ buildConfig }) => {
 				_buildConfig = buildConfig;

packages/integrations/netlify/src/integration-edge-functions.ts

@@ -135,6 +135,10 @@ export function netlifyEdgeFunctions({ dist }: NetlifyEdgeFunctionsOptions = {})
 			'astro:config:done': ({ config, setAdapter }) => {
 				setAdapter(getAdapter());
 				_config = config;
+
+				if(config.mode === 'static') {
+					console.warn(`@astrojs/netlify does not support static mode.`);
+				}
 			},
 			'astro:build:start': async ({ buildConfig }) => {
 				_buildConfig = buildConfig;

packages/integrations/netlify/src/integration-functions.ts

@@ -35,6 +35,10 @@ function netlifyFunctions({
 			'astro:config:done': ({ config, setAdapter }) => {
 				setAdapter(getAdapter({ binaryMediaTypes }));
 				_config = config;
+
+				if(config.mode === 'static') {
+					console.warn(`@astrojs/netlify does not support static mode.`);
+				}
 			},
 			'astro:build:start': async ({ buildConfig }) => {
 				entryFile = buildConfig.serverEntry.replace(/\.m?js/, '');

packages/integrations/node/src/index.ts

@@ -12,8 +12,12 @@ export default function createIntegration(): AstroIntegration {
 	return {
 		name: '@astrojs/node',
 		hooks: {
-			'astro:config:done': ({ setAdapter }) => {
+			'astro:config:done': ({ setAdapter, config }) => {
 				setAdapter(getAdapter());
+
+				if(config.mode === 'static') {
+					console.warn(`@astrojs/node does not support static mode.`);
+				}
 			},
 		},
 	};