Don't try to load partytown scripts in the main thread during view tr…

…ansitions (#9658)
withastro · Jan 11, 2024 · a3b5695 · a3b5695
1 parent e72efd6
commit a3b5695
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/early-taxis-love.md b/.changeset/early-taxis-love.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes an issue caused by trying to load text/partytown scripts during view transitions
diff --git a/packages/astro/src/transitions/router.ts b/packages/astro/src/transitions/router.ts
@@ -151,12 +151,14 @@ function runScripts() {
 	let wait = Promise.resolve();
 	for (const script of Array.from(document.scripts)) {
 		if (script.dataset.astroExec === '') continue;
+		const type = script.getAttribute('type');
+		if (type && type !== 'module' && type !== 'text/javascript') continue;
 		const newScript = document.createElement('script');
 		newScript.innerHTML = script.innerHTML;
 		for (const attr of script.attributes) {
 			if (attr.name === 'src') {
 				const p = new Promise((r) => {
-					newScript.onload = r;
+					newScript.onload = newScript.onerror = r;
 				});
 				wait = wait.then(() => p as any);
 			}