Update Solid ecosystem package logic to include packages with peerDep… (

#6934) * Update Solid ecosystem package logic to include packages with peerDep of Solid * Remove solid as a noExternal * Update the changeset
withastro · May 2, 2023 · b6797fc · b6797fc
1 parent 72c6bf0
commit b6797fc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/purple-lamps-sleep.md b/.changeset/purple-lamps-sleep.md
@@ -0,0 +1,5 @@
+---
+"@astrojs/solid-js": patch
+---
+
+Allow Solid ecosystem packages to not need special export map configuration. By default Solid is now treated as an external package in SSR, so any other dependent packages will receive the same instance.
diff --git a/packages/integrations/solid/src/index.ts b/packages/integrations/solid/src/index.ts
@@ -47,7 +47,7 @@ async function getViteConfiguration(isDev: boolean, astroConfig: AstroConfig) {
 		ssr: {
 			target: 'node',
 			external: ['babel-preset-solid', ...solidPkgsConfig.ssr.external],
-			noExternal: ['solid-js', ...solidPkgsConfig.ssr.noExternal],
+			noExternal: [...solidPkgsConfig.ssr.noExternal],
 		},
 	};
 }