Revert "Removes trailing dash from generated slugs in markdown (#3044)"

This reverts commit 8530cce.
withastro · Jul 18, 2022 · f5c9d8e · f5c9d8e
1 parent 4555c8c
commit f5c9d8e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/.changeset/cold-bears-sneeze.md b/.changeset/cold-bears-sneeze.md
diff --git a/packages/markdown/remark/src/rehype-collect-headers.ts b/packages/markdown/remark/src/rehype-collect-headers.ts
@@ -53,11 +53,7 @@ export default function createCollectHeaders() {
 							node as any
 						).value = `<${node.tagName} id={${node.properties.id}}>${raw}</${node.tagName}>`;
 					} else {
-						let slug = slugger.slug(text);
-
-						if (slug.endsWith('-')) slug = slug.slice(0, -1);
-
-						node.properties.id = slug;
+						node.properties.id = slugger.slug(text);
 					}
 				}
 

diff --git a/packages/markdown/remark/test/expressions.test.js b/packages/markdown/remark/test/expressions.test.js
@@ -54,7 +54,7 @@ describe('expressions', () => {
 		chai
 			.expect(code)
 			.to.equal(
-				'<h1 id="-foo--is-a-shorthand-for--foo-foo"><code is:raw>{ foo }</code> is a shorthand for <code is:raw>{ foo: foo }</code></h1>'
+				'<h1 id="-foo--is-a-shorthand-for--foo-foo-"><code is:raw>{ foo }</code> is a shorthand for <code is:raw>{ foo: foo }</code></h1>'
 			);
 	});