Skip to content

Commit

Permalink
view transition's form handling honors default prevention (#9486)
Browse files Browse the repository at this point in the history
* add missing check to honor prevented default

* added changeset

* Update .changeset/fresh-games-confess.md

Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>

---------

Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
  • Loading branch information
martrapp and florian-lefebvre authored Dec 20, 2023
1 parent 5062d27 commit f6714f6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/fresh-games-confess.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes View Transition's form submission prevention, allowing `preventDefault` to be used.
2 changes: 1 addition & 1 deletion packages/astro/components/ViewTransitions.astro
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const { fallback = 'animate' } = Astro.props;

document.addEventListener('submit', (ev) => {
let el = ev.target as HTMLElement;
if (el.tagName !== 'FORM' || isReloadEl(el)) {
if (el.tagName !== 'FORM' || ev.defaultPrevented || isReloadEl(el)) {
return;
}
const form = el as HTMLFormElement;
Expand Down

0 comments on commit f6714f6

Please sign in to comment.