Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types in @astrojs/partytown not exported from package #8723

Closed
1 task
jerry84 opened this issue Oct 2, 2023 · 2 comments · Fixed by #8740
Closed
1 task

Types in @astrojs/partytown not exported from package #8723

jerry84 opened this issue Oct 2, 2023 · 2 comments · Fixed by #8740
Labels
- P2: nice to have Not breaking anything but nice to have (priority) help wanted Please help with this issue!

Comments

@jerry84
Copy link

jerry84 commented Oct 2, 2023

Astro Info

Astro                    v3.1.0
Node                     v18.16.0
System                   macOS (arm64)
Package Manager          pnpm/npm
Output                   static
Adapter                  none
Integrations             @astrojs/partytown
                         @astrojs/vue

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When using @astrojs/partytown as preset It would be great to provide the Partytown config options in the same way as using it as an integration directly. it is currently not able to import the types PartyrownOptions and/or PartytownConfig that are used in the package.

This is currently not possible.

import type { PartytownOptions } from '@astrojs/partytown';

type PresetConfig = {
  partytownOptions?: PartytownOptions;
}

What's the expected result?

It should be possible to import types for PartytownOptions and/or PartytownConfig from @astrojs/partytown

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-humest?file=src%2Fastro-presets.config.ts

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Oct 2, 2023
@florian-lefebvre
Copy link
Member

If this issue is confirmed, I'd like to handle it

@bluwy
Copy link
Member

bluwy commented Oct 3, 2023

Sounds fine to me to export PartytownOptions.

@bluwy bluwy added help wanted Please help with this issue! - P2: nice to have Not breaking anything but nice to have (priority) and removed needs triage Issue needs to be triaged labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) help wanted Please help with this issue!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants