Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro Dev Toolbar Audit: False positive on anchors #9422

Closed
1 task
pauchiner opened this issue Dec 13, 2023 · 0 comments · Fixed by #9483
Closed
1 task

Astro Dev Toolbar Audit: False positive on anchors #9422

pauchiner opened this issue Dec 13, 2023 · 0 comments · Fixed by #9483
Assignees
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: toolbar Related to dev toolbar (scope)

Comments

@pauchiner
Copy link

Astro Info

Astro                    v4.0.4
Node                     v21.1.0
System                   macOS (arm64)
Package Manager          yarn
Output                   static
Adapter                  none
Integrations             @astrojs/preact

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

In the minimal reproducible example, i have two anchors, within these anchors there is an svg, in the first case the indentation of the html itself generates a false positive in the audit panel of the dev toolbar:

Captura de pantalla 2023-12-13 a las 14 46 10

Element in red

<a aria-label="Astro" href="https://astro.build" target="_blank"><svg width="48" height="49" viewBox="0 0 48 49" fill="none">...</svg></a>

Element in green

<a aria-label="Astro" href="https://astro.build" target="_blank"><svg width="48" height="49" viewBox="0 0 48 49" fill="none">...</svg> </a>

The only thing that changes between this anchors is the space at the end of the anchor tag </a>

I also check lighthouse and gives a 10/10 in accessibility.

What's the expected result?

The expected result is that both elements have the same audit, not conditioned by the parser.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-dqtpmf?file=src%2Fpages%2Findex.astro

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 13, 2023
@Princesseuh Princesseuh added - P3: minor bug An edge case that only affects very specific usage (priority) feat: toolbar Related to dev toolbar (scope) and removed needs triage Issue needs to be triaged labels Dec 14, 2023
@Princesseuh Princesseuh self-assigned this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: toolbar Related to dev toolbar (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants