fix(a11y): Fix some audit false positives #9483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4860291 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
⚖️ Bundle Size CheckLatest commit: 4860291
|
github-actions
bot
added
the
pr: docs
Princesseuh
commented
Dec 19, 2023
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
natemoo-re
reviewed
Dec 19, 2023
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
delucis
approved these changes
Dec 19, 2023
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
| const inputChild = element.querySelector('input'); | ||
| if (!inputChild?.textContent) return true; | ||
| // Label must be associated with a control | ||
| const hasFor = element.hasAttribute('for'); |
There was a problem hiding this comment.
Should we also be checking that the for attribute element actually exists? Or does another audit take care of that?
There was a problem hiding this comment.
Not sure I understand what you mean. The line you highlighted checks for for?
There was a problem hiding this comment.
Oh, I just got it, that the element the for is for exists, that's neat. We could do another rule for that, this rule is already a bit overloaded! I'll add it to the backlog.
…1y.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
natemoo-re
approved these changes
Dec 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some small false positives. Additionally rewrote a message to have the same form as the other messages.
Fix #9456
Fix #9422
Testing
Tested manually!
Docs
N/A