create-astro updates #12083
create-astro updates #12083
Conversation
🦋 Changeset detectedLatest commit: eb51757 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: create-astro
github-actions
bot
added
the
pkg: astro
|
Todo:
|
| // @ts-ignore | ||
| export { default as Code } from './Code.astro'; | ||
| // @ts-ignore | ||
| export { default as Debug } from './Debug.astro'; | ||
| // @ts-ignore | ||
| export { default as WelcomeScreen } from './WelcomeScreen.astro'; |
There was a problem hiding this comment.
Maybe Welcome instead of WelcomeScreen?
| 'create-astro': minor | ||
| --- | ||
|
|
||
| Add a question to ask the user which adapter to add. Add an `--add` flag taking a list of integration. |
There was a problem hiding this comment.
Need to talk about TS changes as well
There was a problem hiding this comment.
I think --add should be split to a separate PR to avoid blocking on this review. Sounds it like we can release that independently.
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
| @@ -0,0 +1,172 @@ | |||
| --- | |||
There was a problem hiding this comment.
I think moving the original design here was smart for keeping this PR reviewable! Still, I recall that @FredKSchott wanted to use this as an opportunity to explore a new, more expressive design.
May become a blocker to make the new starter more of a feature we promote. Still on the fence whether merging this change in code structure without a redesign is a good idea.
There was a problem hiding this comment.
For what it's worth, this is on the next branch, so it would only affect new projects using the beta. Even if we merge this right now, there's plenty of time to make the new design before the actual release.
Changes
This PR includes a few changes to the experience of creating a new project in Astro:
// @ts-checkhas been added to all the examples config filesastro checkis no longer enabled by default for the build commandcreate-astronow takes a--addflag, allowing one to add a bunch of integrations in one command.Basic example rework
The basics template has been reworked to provide a more minimal template, allowing it to serve as a mix between "Basics" and "Minimal":
.astro, allowing one to still inspect how you'd achieve things in Astro. This component takes in a props to customise the title, still allowing for the implicit teaching of props. A very basic layout (similar to Emmet'sdoccommand) is included, both to setup basic HTML stuff and teach the user about templates / slotsTesting
Added / updated tests
Docs
We'll update the docs:tm: