Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netlify adapter #2879

Merged
merged 8 commits into from
Mar 25, 2022
Merged

Netlify adapter #2879

merged 8 commits into from
Mar 25, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Adds the Netlify adapter that works with Netlify Functions.
  • Allows integrations to configure the folders where client/server code is written to.

Testing

Not testing adapters, yet.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: b2245e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
astro Patch
@astrojs/netlify Patch
@astrojs/node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 24, 2022
@matthewp matthewp marked this pull request as ready for review March 24, 2022 21:14
matthewp
matthewp commented Mar 24, 2022
View reviewed changes
packages/astro/package.json Outdated Show resolved Hide resolved
natemoo-re
natemoo-re reviewed Mar 24, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, but looking good!

packages/integrations/netlify/readme.md Outdated Show resolved Hide resolved
packages/integrations/netlify/src/index.ts Outdated Show resolved Hide resolved
.changeset/blue-rocks-smoke.md Outdated Show resolved Hide resolved
natemoo-re
natemoo-re reviewed Mar 25, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Saw a few edge cases that might be worth considering.

packages/integrations/netlify/src/netlify-functions.ts Show resolved Hide resolved
packages/integrations/netlify/src/netlify-functions.ts Show resolved Hide resolved
packages/integrations/netlify/src/index.ts Outdated Show resolved Hide resolved
packages/integrations/netlify/readme.md Show resolved Hide resolved
packages/integrations/netlify/readme.md Show resolved Hide resolved
natemoo-re
natemoo-re approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Great work.

@matthewp matthewp merged commit 80034c6 into main Mar 25, 2022
@matthewp matthewp deleted the netlify-2 branch March 25, 2022 16:08
@github-actions github-actions bot mentioned this pull request Mar 25, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@matthewp
Netlify adapter (withastro#2879)
b4e4c87 
* Netlify adapter

* Remove package.json export that doesnt exist

* Fix out path

* Make netlifyFunctions the default

* Make the dist configurable

* Add an export for the functions

* Append of the file exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @natemoo-re