Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused CSS for client:load components #4566

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Remove unused CSS for client:load components #4566

merged 3 commits into from
Aug 31, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 31, 2022

Changes

As client:load components are built in ssr and client, this PR removes the unused CSS in the client build as SSR already builds one for it.

We fix this by tracking all CSS chunks' modules in SSR, then compare them in the client build, removing CSS chunks that also has the same modules.

Thanks @matthewp for the idea.

Testing

Add a test in 0-css

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2022

🦋 Changeset detected

Latest commit: 8502e4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 31, 2022
Comment on lines -8 to -9
// Pure CSS chunks are chunks that only contain CSS.
pureCSSChunks: Set<RenderedChunk>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pureCSSChunks was previously unused. I've re-purposed it as cssChunkModuleIds.

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to unload quality fixes 👏

@bluwy bluwy merged commit 9ad307a into main Aug 31, 2022
@bluwy bluwy deleted the fix-css-dupe branch August 31, 2022 14:36
@astrobot-houston astrobot-houston mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants