Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings for solidjs dependency crawling #5089

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 14, 2022

Changes

The latest solidjs integration crawls for solidjs libraries, but this generates a warning for pure ESM libraries that do not have a CJS entrypoint (since it relies on require.resolve).

Since the crawling is best-effort, we can suppress the warning here.

Testing

Tested with a local project.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

🦋 Changeset detected

Latest commit: 1a167e6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) labels Oct 14, 2022
@bluwy bluwy merged commit 0173c2b into main Oct 14, 2022
@bluwy bluwy deleted the solid-suppress-dep branch October 14, 2022 09:51
@astrobot-houston astrobot-houston mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: solid Related to Solid (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants