Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Vite user config for third-party packages #5345

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 10, 2022

Changes

  • Upgrade vitefu from 0.1.0 to 0.2.0 - It's a breaking bump but for an API we're not using so we're safe.
  • Pass Vite user config to vitefu crawlFrameworkPackages so that the generated Vite config respects the user config. This helps the user to make a workaround if there's any issues with it.

Testing

Existing tests should pass.

Docs

N/A. In most case this should be transparent to the users.

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022

🦋 Changeset detected

Latest commit: 2637a0b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) labels Nov 10, 2022
@bluwy bluwy merged commit 3ae2a96 into main Nov 11, 2022
@bluwy bluwy deleted the third-party-improve branch November 11, 2022 06:22
@astrobot-houston astrobot-houston mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: solid Related to Solid (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants