Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node adapter: handle prerendering and serving with query params #6110

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Feb 2, 2023

Changes

Testing

Prerendering tests added, including this scenario

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023

🦋 Changeset detected

Latest commit: ef13fd9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 2, 2023
@matthewp matthewp merged commit 67ccec9 into main Feb 3, 2023
@matthewp matthewp deleted the query-params-node branch February 3, 2023 00:10
@astrobot-houston astrobot-houston mentioned this pull request Feb 3, 2023
matthewp added a commit that referenced this pull request Feb 3, 2023
* Node adapter: handle prerendering and serving with query params

* Adding a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any query parameter breaks pre-rendered routes completely
2 participants