Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel array rendering #7136

Merged
merged 6 commits into from
Jun 2, 2023

Conversation

johannesspohr
Copy link
Contributor

Changes

This uses the existing rendering parallelization for array children as well
Fixes #7127

Testing

Extended the parallel rendering test

Docs

Changeset added

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: 115f00a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 19, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, but the fix looks great!

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bluwy bluwy merged commit fea3069 into withastro:main Jun 2, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jun 2, 2023
@johannesspohr johannesspohr deleted the parallel-array-rendering branch June 2, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel rendering does not respect arrays
3 participants