Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vercel redirects with trailingSlash always #7447

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 22, 2023

Changes

Fix #7444

It was generating redirects from / to //, which was causing infinite redirects. I've removed creating redirects for the root page, which should fix this.

I don't see @astrojs/underscore-redirects creating redirects based on trailingSlash so they might be unaffected.

Testing

Added test in vercel

Docs

n/a. bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

🦋 Changeset detected

Latest commit: 742f9f9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 22, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's 🚢 it

@bluwy bluwy merged commit 32bde96 into main Jun 22, 2023
@bluwy bluwy deleted the fix-vercel-redirect branch June 22, 2023 15:40
@astrobot-houston astrobot-houston mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trailingSlash: "always" break on Vercel
2 participants