feat: use external @astrojs/check #7892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 74acb55 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
!preview astro-check |
bluwy
reviewed
Aug 1, 2023
Princesseuh
force-pushed
the
feat/external-astro-check
branch
from
692d8c6
to
81140c7
Compare
bluwy
reviewed
Aug 1, 2023
bluwy
approved these changes
Aug 1, 2023
ematipico
reviewed
Aug 1, 2023
Princesseuh
force-pushed
the
feat/external-astro-check
branch
from
2ad1412
to
3f15fbf
Compare
Merged
ematipico
pushed a commit
that referenced
this pull request
Aug 3, 2023
* feat: use @astrojs/check * fix: what happened in my rebase?? * nit: adjust with feedback
ematipico
pushed a commit
that referenced
this pull request
Aug 8, 2023
* feat: use @astrojs/check * fix: what happened in my rebase?? * nit: adjust with feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Core part of withastro/language-tools#613. This PR makes it so we ask the user to install the package if they don't have it and actually use the package. The last primitive will also be usable for any future features we'd like to have an external package for
Testing
The tests for
astro checkshould still pass! Tests for the checking behaviour are done in both@astrojs/checkand@astrojs/language-serverDocs
withastro/docs#3756 (comment)