Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove markdown component #7931

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Remove markdown component #7931

merged 2 commits into from
Aug 4, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 3, 2023

Changes

  • Remove @astrojs/markdown-component package entirely.
  • Remove markdown and Astro.__renderMarkdown support. This should reduce the SSR bundle size.

Testing

Existing tests should pass.

Docs

Added changeset for simple migration guide.

/cc @withastro/maintainers-docs for feedback!

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e29180f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 3, 2023
@matthewp
Copy link
Contributor

matthewp commented Aug 3, 2023

viking-funeral

@ematipico ematipico requested a review from a team as a code owner August 3, 2023 15:05
@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Aug 3, 2023
@bluwy bluwy force-pushed the remove-markdown-component branch from 266462e to f32a6be Compare August 4, 2023 07:44
@github-actions github-actions bot removed pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: lit Related to Lit (scope) labels Aug 4, 2023
@github-actions github-actions bot removed pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Aug 4, 2023
@bluwy bluwy merged commit 2eb6252 into next Aug 4, 2023
13 checks passed
@bluwy bluwy deleted the remove-markdown-component branch August 4, 2023 09:27
@astrobot-houston astrobot-houston mentioned this pull request Aug 4, 2023
Merged
@bluwy bluwy mentioned this pull request Aug 4, 2023
Closed
ematipico pushed a commit that referenced this pull request Aug 8, 2023
@bluwy @ematipico
Remove markdown component (#7931)
3c31008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@matthewp matthewp matthewp approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bluwy @matthewp @ematipico @sarah11918