Mt scroll behavior #8184
Merged
Mt scroll behavior #8184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpected browser behavior
🦋 Changeset detectedLatest commit: de4bafa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Aug 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If
scroll-behavior: smoothis set to the<html>element, the scrolling behavior of the navigation differs greatly once<ViewTransitions/>is added to a page.Unfortunately, not all browsers behave the same way.
I started to make some decisions based on browser detection, but then decided against it.
I took care of the main anomaly, which is that scrolling to a hash mark usually jumps to the top of the page first in Safari and the Chromium-based browsers.
I also use
scrollIntoView()to scroll to hash marks because it respects CSSscroll-padding.Testing
detailed manual test
Docs
As soon as we introduce fine grained controls for users to change behavior