Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@astrojs/vercel): warn user when functionPerRoute is true #8319

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Aug 31, 2023

Changes

We log a warning to the user, because the number of functions emitted could exceed the limit of someone's plan.

Testing

Current tests should pass

Docs

N/A

/cc @withastro/maintainers-docs please check the warning

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

🦋 Changeset detected

Latest commit: a716818

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 31, 2023
@ematipico ematipico force-pushed the revert/function-per-route-vercel branch from 79c816f to a716818 Compare August 31, 2023 12:26
@ematipico ematipico changed the title revert(@astrojs/vercel): functionPerRoute not enabled by default fix(@astrojs/vercel): warn user when functionPerRoute is true Aug 31, 2023
@ematipico ematipico marked this pull request as ready for review August 31, 2023 12:27
@matthewp matthewp requested a review from a team August 31, 2023 12:29
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great addition!

@ematipico ematipico merged commit dc29e0f into main Aug 31, 2023
13 checks passed
@ematipico ematipico deleted the revert/function-per-route-vercel branch August 31, 2023 14:36
@astrobot-houston astrobot-houston mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants