Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel): Don't output an error message for failing to resolve sharp #8354

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

Princesseuh
Copy link
Member

Changes

What the title says. Sharp is always external, so it'll always output a warning but this is not a problem

Testing

Tested it manually, it didn't output a warning, sir

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 893ba14

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 1, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset?

@Princesseuh Princesseuh merged commit 0eb09db into main Sep 1, 2023
4 checks passed
@Princesseuh Princesseuh deleted the fix/vercel-sharp-warning branch September 1, 2023 14:14
@astrobot-houston astrobot-houston mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants