Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve astro info compatability #8730

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Improve astro info compatability #8730

merged 5 commits into from
Oct 3, 2023

Conversation

natemoo-re
Copy link
Member

Changes

  • On Windows terminals, astro info's copy to clipboard feature was copying the entire JSON-encoded string rather than the unencoded string as expected.
  • With some help from @lilnasy, we debugged this and landed on passing the input directly to clip.

Testing

Tested manually

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

🦋 Changeset detected

Latest commit: e6fc2e3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 2, 2023
@natemoo-re natemoo-re merged commit 357270f into main Oct 3, 2023
13 checks passed
@natemoo-re natemoo-re deleted the update-astro-info branch October 3, 2023 20:57
@astrobot-houston astrobot-houston mentioned this pull request Oct 3, 2023
martrapp pushed a commit that referenced this pull request Oct 4, 2023
* Improve `astro info` compatability

* Update packages/astro/src/cli/info/index.ts

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>

* chore: add changeset

* feat(info): add copy to clipboard support on Unix machines with xclip installed

---------

Co-authored-by: Arsh <69170106+lilnasy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants