fix noop overwrite image service regression #8880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9faac4b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
github-actions
bot
added
the
pkg: astro
|
!preview noop-imageservice |
|
/preview fix-noop-override |
1 similar comment
|
/preview fix-noop-override |
alexanderniebuhr
force-pushed
the
nbhr/fix_noop_overwrite_image_service_regression
branch
from
bf49bc8
to
c8db70d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sarah11918
reviewed
Oct 22, 2023
alexanderniebuhr
force-pushed
the
nbhr/fix_noop_overwrite_image_service_regression
branch
from
c8db70d
to
376dc46
Compare
sarah11918
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Just fixed some spaces in the changeset. Otherwise, nice job @alexanderniebuhr .... Docs out!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
alexanderniebuhr
force-pushed
the
nbhr/fix_noop_overwrite_image_service_regression
branch
from
376dc46
to
9faac4b
Compare
github-actions
bot
added
the
pr: docs
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
for context see messages after: https://discord.com/channels/830184174198718474/845430950191038464/1165031078722011238
I've added PRs to the two known edge runtimes:
fix image service denoland/deno-astro-adapter#7
fix(cloudflare): astro asset image service adapters#33