Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update page partials link in CHANGELOG #8927

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Update page partials link in CHANGELOG #8927

merged 2 commits into from
Oct 26, 2023

Conversation

natemoo-re
Copy link
Member

Changes

  • Updates Astro's changelog for 3.4!
  • The page partials links was broken. Now it's not.

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4923aeb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 26, 2023
sarah11918
sarah11918 reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also changed the heading to Page Partials at the last minute, after the main PR was merged.

@natemoo-re @sarah11918
Update packages/astro/CHANGELOG.md
4923aeb 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@natemoo-re natemoo-re merged commit 35c5265 into main Oct 26, 2023
2 checks passed
@natemoo-re natemoo-re deleted the chore/fix-partials-link branch October 26, 2023 17:33
natemoo-re added a commit that referenced this pull request Nov 22, 2023
@natemoo-re @sarah11918
Update page partials link in CHANGELOG (#8927)
539cf6b 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@lilnasy lilnasy lilnasy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natemoo-re @sarah11918 @lilnasy