refactor: dev overlay to make it easier to work with VT #8966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 89c96f8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Princesseuh
commented
Oct 31, 2023
Comment on lines
+2330
to
+2338
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| 'astro-dev-overlay': AstroDevOverlay; | ||
| 'astro-dev-overlay-window': DevOverlayWindow; | ||
| 'astro-dev-overlay-plugin-canvas': DevOverlayCanvas; | ||
| 'astro-dev-overlay-tooltip': DevOverlayTooltip; | ||
| 'astro-dev-overlay-highlight': DevOverlayHighlight; | ||
| } | ||
| } |
There was a problem hiding this comment.
I had forgotten about this thing, it's quite neat.
⚖️ Bundle Size CheckLatest commit: 89c96f8
|
Princesseuh
commented
Oct 31, 2023
Comment on lines
+7
to
+28
| const [ | ||
| { loadDevOverlayPlugins }, | ||
| { default: astroDevToolPlugin }, | ||
| { default: astroAuditPlugin }, | ||
| { default: astroXrayPlugin }, | ||
| { AstroDevOverlay, DevOverlayCanvas }, | ||
| { DevOverlayCard }, | ||
| { DevOverlayHighlight }, | ||
| { DevOverlayTooltip }, | ||
| { DevOverlayWindow }, | ||
| ] = await Promise.all([ | ||
| // @ts-expect-error | ||
| import('astro:dev-overlay'), | ||
| import('./plugins/astro.js'), | ||
| import('./plugins/audit.js'), | ||
| import('./plugins/xray.js'), | ||
| import('./overlay.js'), | ||
| import('./ui-library/card.js'), | ||
| import('./ui-library/highlight.js'), | ||
| import('./ui-library/tooltip.js'), | ||
| import('./ui-library/window.js'), | ||
| ]); |
There was a problem hiding this comment.
Moved the imports into the DOMContentLoaded, that way we really do the big things outside of the page load
Princesseuh
commented
Oct 31, 2023
Comment on lines
+36
to
+43
| view-transition-name: astro-dev-overlay; | ||
| display: contents; | ||
| } | ||
|
|
||
| ::view-transition-old(astro-dev-overlay), | ||
| ::view-transition-new(astro-dev-overlay) { | ||
| animation: none; | ||
| } |
There was a problem hiding this comment.
All of this is required to ensure animations don't affect the dev overlay, otherwise it might move, get faded away etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The diff looks really messy, but to summarize the changes here:
Testing
Tests should pass!
Docs
N/A, just a bug fix. We could have a section on making your plugin work with VT, though...