Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): Fix SVG icons not showing properly in the overflow menu #9235

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

Princesseuh
Copy link
Member

Changes

What the title says. I also did a small refactor to make the plugin icon stuff nicer to use

Testing

Tested manually

Docs

N/A

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: 030a731

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 29, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Nov 30, 2023
@Princesseuh Princesseuh merged commit 9c2342c into next Nov 30, 2023
4 checks passed
@Princesseuh Princesseuh deleted the fix/overlay-overflow branch November 30, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants