Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Svelte client error #9530

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Forward Svelte client error #9530

merged 1 commit into from
Dec 27, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 27, 2023

Changes

fix #9158

I'm not sure why we have the catch there, I traced it and it started from this PR: #231 (way way back)

I don't think there's harm in not catching the errors as other frameworks didn't do the same either.

Testing

Existing tests should pass.

Docs

n/a. bug fix.

Copy link

changeset-bot bot commented Dec 27, 2023

🦋 Changeset detected

Latest commit: 246bafa

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review labels Dec 27, 2023
@matthewp matthewp merged commit 337ca50 into main Dec 27, 2023
13 checks passed
@matthewp matthewp deleted the forward-svelte-error branch December 27, 2023 17:35
@astrobot-houston astrobot-houston mentioned this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte errors are not forwarded to user
2 participants