Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redirects): correctly compute the status code in redirects #9657

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

ematipico
Copy link
Member

Changes

Closes PLT-1371
Closes #9568

Testing

I tested it locally with the use case provided

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: e112043

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 10, 2024
Comment on lines +481 to +485
if (typeof to === 'object') {
return r.route === to.destination;
} else {
return r.route === to;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to find the route in case to is the object

Comment on lines +39 to +40
if (routeData && typeof redirectRoute.redirect === 'object') {
return redirectRoute.redirect.status;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were checking the incorrect data

@ematipico ematipico merged commit a4f90d9 into main Jan 10, 2024
13 checks passed
@ematipico ematipico deleted the fix/custom-status-code branch January 10, 2024 13:47
@astrobot-houston astrobot-houston mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom status code does not seem to be respected in configured redirects
2 participants