Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for adonisrc.ts for Adonis.js 'node ace' command #2450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eduwass
Copy link
Contributor

@eduwass eduwass commented Sep 7, 2024

Looks like the latest version of AdonisJS does not ship with .adonisrc.json but rather adonisrc.ts so this checks for both.

Improve generateSpec function to check for both .adonisrc.json and adonisrc.ts files. This ensures compatibility with projects using either configuration file.

  • Refactor the use of executeShellCommand to check for .adonisrc.json.
  • Add a new check for the presence of adonisrc.ts.

Improve generateSpec function to check for both .adonisrc.json and adonisrc.ts files. This ensures compatibility with projects using either configuration file.

- Refactor the use of executeShellCommand to check for .adonisrc.json.
- Add a new check for the presence of adonisrc.ts.
@withfig-bot
Copy link
Collaborator

Overview

src/node.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @eduwass,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants