This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
fix(quantity): add several name length limits #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arinono
force-pushed
the
feat-platform-client-1407-text-overflow
branch
8 times, most recently
from
adf78f8
to
eeb37c1
Compare
Arinono
force-pushed
the
feat-platform-client-1407-text-overflow
branch
from
3998dcf
to
854f72a
Compare
Arinono
force-pushed
the
feat-platform-client-1407-text-overflow
branch
3 times, most recently
from
2c3b38f
to
0719bed
Compare
Arinono
changed the title
srieding
reviewed
Jan 23, 2023
srieding
reviewed
Jan 25, 2023
srieding
suggested changes
Jan 25, 2023
Arinono
force-pushed
the
feat-platform-client-1407-text-overflow
branch
2 times, most recently
from
e44a6c2
to
1cd34ee
Compare
srieding
reviewed
Jan 27, 2023
srieding
approved these changes
Jan 27, 2023
BREAKING CHANGE localised entities names are now limited in length
Arinono
force-pushed
the
feat-platform-client-1407-text-overflow
branch
from
1cd34ee
to
75937ee
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
## [18.0.0](v17.73.1...v18.0.0) (2023-01-30) ### ⚠ BREAKING CHANGES * **quantity:** localised entities names are now limited in length ### Bug Fixes * **quantity:** add several name length limits ([#356](#356)) ([4eb8bd5](4eb8bd5))
|
🎉 This PR is included in version 18.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors
@Arinono
Issue
Refs (and used by, kinda, not required, but better) withthegrid/platform-client#1407
Used by https://github.com/withthegrid/platform/pull/1907
While I was working on the ticket above: inputing very long names everywhere, I got an API error for a
quantity.unitname being too long. DB schema has avarchar(10), and the SDK doesn't check this.So I'm opening a PR to add this to the SDK.
👀
As discussed with Rob, this won't be breaking change(s), since the API would have blocked the requests anyways.I introduced one 🤓
Implementation details
quantity.unit
Limiting to 10 chars to follow the DB schema
unit name longer than 10 chars
Entities names 🚨 BREAKING 🚨 (stringOrTranslations)
The names of localisable entities were not limited in length.
So I updated the helper that was giving the schema for these to introduce a max length of
255for version 9 (new version) onwards.measurement-filter
Add limit of
100on name and255on description (add and update)webhook
Limited name to
255