This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: warning with default archive templates when queryId is missing #10596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
dinhtungdu
added
status: needs review
skip-changelog
imanish003
approved these changes
Aug 15, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
nielslange
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Thanks for working on this, @dinhtungdu. The PR works as expected and I'll cherry-pick it into 10.9.0 after you merged it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10200 introduces a PHP warning for block themes using the default archive templates that indicate the
queryIdis missing. This PR fixes that warning by addingqueryIdto theProducts (Beta)block in the blockifed archive templates.We need the
queryIdfor the pagination to work, so we decided to include thequeryIdto the template file. Doing so is safe because we only includequeryIdinside templates, every newProducts (Block)orQuery Loopblock will have a differentqueryIdautogenerated.Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
N/a
Changelog
N/a