Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product review And Variation Fix Store Api #10950

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

shm379
Copy link

@shm379 shm379 commented Sep 14, 2023

What

Fixes Product Review Parent Id in Schema and Add Parent review From Request
And add variation gallery images to Product Schema

Why

Testing Instructions

Please consider any edge cases this change may have, and also other areas of the product this may impact.

  • Do not include in the Testing Notes
  • Should be tested by the development team exclusively

Screenshots or screencast

Before After

WooCommerce Visibility

Required:

  • WooCommerce Core
  • Feature plugin
  • Experimental
  • N/A

Checklist

Required:

  • This PR has either a [type] label or a [skip-changelog] label.
  • This PR is assigned to a milestone.

Conditional:

  • This PR has a changelog description (if [skip-changelog] label is not present).
  • This PR adds/removes a feature flag & I've updated this doc.
  • This PR adds/removes an experimental interfaces, and I've updated this doc.
  • This PR has been accessibility tested.
  • This PR has had any necessary documentation added/updated.

Changelog

Add suggested changelog entry here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

This PR has been marked as stale because it has not seen any activity within the past 7 days. Our team uses this tool to help surface pull requests that have slipped through review.

If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Oct 4, 2023
@github-actions github-actions bot removed the status: stale Stale issues and PRs have had no updates for 60 days. label Nov 26, 2023
@kmanijak
Copy link
Contributor

kmanijak commented Dec 7, 2023

Hi @shm379!

Could you provide more details and context about this contribution in the PR description? What are the cases that it covers or what's the bug it fixes? Also, would be great to provide testing steps to verify that change. 🖐️

I’d like you to know that this weekend (8-9 December) WooCommerce Blocks repo will be migrated to WooCommerce monorepo.

However, open PRs won’t be migrated. That means open PRs have to be merged by the end of this week or otherwise, you’ll have to open/recreate a new PR in a monorepo post-migration if you’re interested in finalizing this contribution.

Thanks!

Copy link
Contributor

This PR has been marked as stale because it has not seen any activity within the past 7 days. Our team uses this tool to help surface pull requests that have slipped through review.

If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: stale Stale issues and PRs have had no updates for 60 days. team: Kirigami & Origami type: community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants