Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fixing fatal error found when upgrading WooCommerce plugin #12179

Closed
wants to merge 1 commit into from

Conversation

davefx
Copy link

@davefx davefx commented Jan 15, 2024

What

Fixes woocommerce/woocommerce#43649

Why

Adds an extra check so, if $images hasn't been defined, the site doesn't generate a fatal error

Testing Instructions

Please consider any edge cases this change may have, and also other areas of the product this may impact.

  • Do not include in the Testing Notes
  • Should be tested by the development team exclusively

Screenshots or screencast

Before After

WooCommerce Visibility

Required:

  • WooCommerce Core
  • Feature plugin
  • Experimental
  • N/A

Checklist

Required:

  • This PR has either a [type] label or a [skip-changelog] label.
  • This PR is assigned to a milestone.

Conditional:

  • This PR has a UI change and has been cross-browser tested at different viewport sizes on both the frontend and in the editor.
  • This PR has a changelog description (if [skip-changelog] label is not present).
  • This PR adds/removes a feature flag & I've updated this doc.
  • This PR adds/removes an experimental interfaces, and I've updated this doc.
  • This PR has been accessibility tested.
  • This PR has had any necessary documentation added/updated.

Changelog

Fixes a potential fatal error with certain themes and plugins if $images are not defined when rendering patterns.

Copy link
Contributor

Thank you for your interest in contributing to WooCommerce!

WooCommerce Blocks has been merged into the WooCommerce Monorepo.

From now on, please open any issues or pull requests in the woocommerce/woocommerce repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error after upgrading WooCommerce plugin
1 participant