Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Hide Cart and Checkout blocks from the widget editor #4303

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jun 2, 2021

Closes #4190.
Closes #4191.

After some more discussion (pca54o-1pT-p2#comment-1929) we decided to hide the Cart block and Checkout blocks from the widget editor. In the future we will have a 'Minicart block' (#4138) which will serve the use-case of showing the cart contents in a widget area. Regarding the Checkout block, we don't see any use-case for it in a widget area.

How to test the changes in this Pull Request:

  1. Using a classic theme (ie: Storefront) with Gutenberg enabled, go to Appearance > Widgets.
  2. Verify you can't add the Cart block or the Checkout block. (You will see a widget called Cart, that's the widget from WC core and is not related to this PR, so ignore it).
  3. Now go to Appearance > Customize > Widgets and open a widget area.
  4. Verify you can't add the Cart block or the Checkout block either.

Changelog

Hide the Cart and Checkout blocks from the new block-based widget editor.

@Aljullu Aljullu added the focus: FSE Work related to prepare WooCommerce for FSE. label Jun 2, 2021
@Aljullu Aljullu self-assigned this Jun 2, 2021
@Aljullu Aljullu requested a review from a team as a code owner June 2, 2021 10:19
@Aljullu Aljullu requested review from ralucaStan and removed request for a team June 2, 2021 10:20
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

Size Change: 0 B

Total Size: 986 kB

ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 7.98 kB 0 B
build/active-filters.js 7.53 kB 0 B
build/all-products-frontend.js 34.7 kB 0 B
build/all-products.js 36.5 kB 0 B
build/all-reviews.js 9.15 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.39 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.95 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 334 B 0 B
build/atomic-block-components/add-to-cart-frontend.js 8.75 kB 0 B
build/atomic-block-components/add-to-cart.js 7.8 kB 0 B
build/atomic-block-components/button-frontend.js 1.73 kB 0 B
build/atomic-block-components/button.js 844 B 0 B
build/atomic-block-components/category-list-frontend.js 469 B 0 B
build/atomic-block-components/category-list.js 478 B 0 B
build/atomic-block-components/image-frontend.js 1.66 kB 0 B
build/atomic-block-components/image.js 1.3 kB 0 B
build/atomic-block-components/price-frontend.js 1.98 kB 0 B
build/atomic-block-components/price.js 2.01 kB 0 B
build/atomic-block-components/rating-frontend.js 521 B 0 B
build/atomic-block-components/rating.js 525 B 0 B
build/atomic-block-components/sale-badge-frontend.js 470 B 0 B
build/atomic-block-components/sale-badge.js 474 B 0 B
build/atomic-block-components/sku-frontend.js 389 B 0 B
build/atomic-block-components/sku.js 393 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 569 B 0 B
build/atomic-block-components/stock-indicator.js 572 B 0 B
build/atomic-block-components/summary-frontend.js 906 B 0 B
build/atomic-block-components/summary.js 910 B 0 B
build/atomic-block-components/tag-list-frontend.js 464 B 0 B
build/atomic-block-components/tag-list.js 472 B 0 B
build/atomic-block-components/title-frontend.js 1.41 kB 0 B
build/atomic-block-components/title.js 1.26 kB 0 B
build/attribute-filter-frontend.js 17.7 kB 0 B
build/attribute-filter.js 11.4 kB 0 B
build/blocks-checkout-editor.js 10.4 kB 0 B
build/blocks-checkout.js 19.6 kB 0 B
build/blocks.js 3.51 kB 0 B
build/cart-frontend.js 77.7 kB 0 B
build/cart.js 44.2 kB 0 B
build/checkout-frontend.js 81.8 kB 0 B
build/checkout.js 46.5 kB 0 B
build/editor-rtl.css 14.9 kB 0 B
build/editor.css 14.9 kB 0 B
build/featured-category.js 7.23 kB 0 B
build/featured-product.js 9.4 kB 0 B
build/handpicked-products.js 5.89 kB 0 B
build/price-filter-frontend.js 14.2 kB 0 B
build/price-filter.js 9.3 kB 0 B
build/price-format.js 1.37 kB 0 B
build/product-best-sellers.js 6.12 kB 0 B
build/product-categories.js 3.24 kB 0 B
build/product-category.js 6.99 kB 0 B
build/product-new.js 6.28 kB 0 B
build/product-on-sale.js 6.62 kB 0 B
build/product-search.js 2.56 kB 0 B
build/product-tag.js 6.1 kB 0 B
build/product-top-rated.js 6.26 kB 0 B
build/products-by-attribute.js 7.22 kB 0 B
build/reviews-by-category.js 11.2 kB 0 B
build/reviews-by-product.js 12.7 kB 0 B
build/reviews-frontend.js 8.94 kB 0 B
build/single-product-frontend.js 38.1 kB 0 B
build/single-product.js 9.65 kB 0 B
build/style-rtl.css 18.8 kB 0 B
build/style.css 18.8 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 6.54 kB 0 B
build/vendors-style-rtl.css 1.05 kB 0 B
build/vendors-style.css 1.05 kB 0 B
build/vendors.js 242 kB 0 B
build/wc-blocks-data.js 10.6 kB 0 B
build/wc-blocks-google-analytics.js 1.99 kB 0 B
build/wc-blocks-middleware.js 1.48 kB 0 B
build/wc-blocks-registry.js 2.74 kB 0 B
build/wc-payment-method-bacs.js 812 B 0 B
build/wc-payment-method-cheque.js 807 B 0 B
build/wc-payment-method-cod.js 903 B 0 B
build/wc-payment-method-paypal.js 844 B 0 B
build/wc-payment-method-stripe.js 12.4 kB 0 B
build/wc-settings.js 2.93 kB 0 B
build/wc-shared-context.js 1.54 kB 0 B
build/wc-shared-hocs.js 1.73 kB 0 B

compressed-size-action

@Aljullu Aljullu added the type: enhancement The issue is a request for an enhancement. label Jun 2, 2021
Copy link
Contributor

@ralucaStan ralucaStan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👏

@Aljullu Aljullu force-pushed the fix/hide-cart-checkout-widget-editor branch from 65b7f80 to 2ec649e Compare June 3, 2021 07:38
@Aljullu Aljullu merged commit e23161e into trunk Jun 3, 2021
@Aljullu Aljullu deleted the fix/hide-cart-checkout-widget-editor branch June 3, 2021 07:50
@Aljullu Aljullu added this to the 5.3.0 milestone Jun 3, 2021
@jeffpaul
Copy link

@Aljullu @ralucaStan we got a report related to this in WordPress core, see here. Could you confirm if what Olga Gleckler reported in WP Core is in fact intended as a result from this PR or not?

@Aljullu
Copy link
Contributor Author

Aljullu commented Jun 22, 2021

Thanks for the ping @jeffpaul, I answered directly in the ticket. The issues were not related to this PR but instead to this two: #3626 and #4362. The first one is fixed and the second one currently under our radar.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: FSE Work related to prepare WooCommerce for FSE. type: enhancement The issue is a request for an enhancement.
Projects
None yet
3 participants