-
Notifications
You must be signed in to change notification settings - Fork 219
Reference Mini Cart drawer preview dynamically #9912
Conversation
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
Size Change: -14 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this issue and fixing it, @nielslange. I left one comment about removing an unnecessary slash, but besides that, LGTM.
Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
* Reference Mini Cart drawer preview dynamically * Update assets/js/blocks/mini-cart/edit.tsx Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> --------- Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Fixes #9910
In #9420, we introduced the Mini Cart drawer preview. In #9756, we added RTL support for the preview. While testing the 10.5.0 release, I noticed that the preview only works locally when the plugin slug is
woocommerce-blocks
. When using the plugin online, the plugin uses the old slugwoocommerce-gutenberg-products-block
. This leads to the fact that the preview is no longer visible.In this PR, I replaced the hardcoded preview address with a dynamic one. This ensures that the preview can be loaded independent of the plugin slug.
Screenshots
Testing
User Facing Testing
woocommerce-blocks
.WooCommerce Visibility